The existing sps expose arc command has arguments to switchOn lamps and allow for warmingTime. I will add per-lamp args which specify the lamp on times, e.g. qth=15 or ar=10, which will be incompatible with the existing args (i.e. if a per-lamp arg is given the switchOn, etc. args cannot also be given.)

Until the dcb actor is updated to use the setup-then-go command structure of the pfilamps I will only allow one lamp.

The expose arc command creates and "runs" an Arc/Sequence object, which knows about the existing lamp logic. I will instead define and use a different Sequence subclass which uses the "pfilamps" open-then-lamp logic.

No matter how completely and correctly we do this, both the spsActor expose command and the dcbActor lamp control commands and logic will need to changed.

I don't think I can do this as anything other than a quick hack.

Long comment, mostly so that arnaud.lefur knows what I have damaged and why.

dcbActor has grown pflampsActor-style prepare neon=S.S halogen=S.S argon=S.S, etc. and go delay=SS commands. The delay is a temporary hack to avoid working on the enuActor shutter commands for this ticket.

iicActor has grown arc neon=S.S argon=S.S and flat halogen=S.S variants, which bypass all the dcbOn and dcbOff parsing and handling. If using the new variants, iic arranges to call the dcb prepare lamps command, and passes doLamps to the sps expose commands to get them to change their internal sequences.

The spsActor expose arc and expose flat commands have grown a doLamps option. If they get that they call dcb go delay=2 after the detector wipe and before the shutter open command is sent. The disgusting dcb go delay=SS hack is used because exposure timing is currently driven by the enu shutter expose exptime=S.S command blocking for exptime seconds then closing the shutter. We need to split that so that the dcb go can be issued immediately after the shutters have opened.

EXPTIME will be the lamp on time; the actual shutter exposure time will be a 4-5 seconds longer.
The lamp cards should be correct. I hope.

Am using the existing DCB lamp names (halogen, neon, argon, hgar, krypton) to avoid confusion. Not sure I love them.

Please see ticket comments for explanation.

Merged and running at Subaru

Tags:

• ics_dcbActor 0.0.8
• ics_iicActor 1.1.6
• ics_spsActor 1.0.2