[INFRA-42] Add SConscript file to bin.src Created: 15/Jul/16 Updated: 19/Jul/16 Resolved: 19/Jul/16 |
|
| Status: | Done |
| Project: | Software Development Infrastructure |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | aritter | Assignee: | swinbank |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2014-15 |
| Reviewers: | aritter |
| Description |
|
Add the SConscript file from https://github.com/lsst/templates/blob/master/bin.src/SConscript to bin.src directories of drp_stella and obs_pfs to create the bin executables |
| Comments |
| Comment by aritter [ 15/Jul/16 ] |
|
Added SConscript file bin.src in drp_stella (tickets/ |
| Comment by swinbank [ 18/Jul/16 ] |
|
Work on obs_pfs is now ready for review: pull request here. I am confused by what's happened on drp_stella: the tickets/ |
| Comment by aritter [ 18/Jul/16 ] |
|
Please go ahead John, sorry for that. Guess I had the wrong branch while working on it. Will double-check from now on... |
| Comment by swinbank [ 18/Jul/16 ] |
|
Thanks! Now ready for review on both: aritter, you did all the work on drp_stella, so I am happy to sign off on that. Can you please check that you are happy with the changes to obs_pfs? |
| Comment by aritter [ 19/Jul/16 ] |
|
Works for me. What was the problem? |
| Comment by swinbank [ 19/Jul/16 ] |
|
The master SConstruct file can be set to only build certain "targets" (effectively, directories). If we don't specify, it uses a default list (which includes bin.src). However, in obs_pfs that default list was being over-ridden to something which did not include bin.src, so the SConscript you added wasn't being included. I edited the SConstruct to use the defaults (plus an appended pfs). |
| Comment by swinbank [ 19/Jul/16 ] |
|
Merged. |