[INFRA-214] Create {{pfs_instdata}} repo for instrument characteristics Created: 05/Aug/18  Updated: 14/Nov/18  Due: 10/Aug/18  Resolved: 13/Sep/18

Status: Done
Project: Software Development Infrastructure
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major
Reporter: hassan Assignee: shimono
Resolution: Done Votes: 0
Labels: GitHub, MCS, SM1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks INFRA-207 Create repo(s) for varying instrument... Open
Epic Link: SM1 Phase Two
Reviewers: hassan

 Description   

/Following INFRA-207, please create a repository with the name pfs_instdata (or if it is more appropriate, ics_instdata following the naming conventions described in https://pfspipe.ipmu.jp/repos.html).

This would be used to store instrument characteristics files.

  • Name of new repository : pfs_instdata or ics_instdata
  • Short description of new repository : storage of instrument characteristics files
  • Responsible institution of the repository (coordination, development): Princeton University
  • Corresponding JIRA project and component: INSTRM, new component
  • License (OSS license is required; default to GPLv2): not applicable

 Comments   
Comment by shimono [ 06/Aug/18 ]

consumer listed in INFRA-207 is not limited to ICS components, so it seems we can (or should?) put it in project wide resource (, no?). so I'd propose to use pfs_instdata...

Comment by hassan [ 06/Aug/18 ]

pfs_instdata is fine with me.

Comment by hassan [ 17/Aug/18 ]

@shimono: when will this ticket be resolved? I see from PR #39 only a minor update to about.html is required. Is that correct?

Comment by shimono [ 17/Aug/18 ]

https://github.com/Subaru-PFS/doc/blob/master/development-management/request.rst#add-new-github-repository
> Once operation procedure finished, this ticket will be marked 'IN REVIEW' with a requestee as a reviewer
> by sysadmin, a requestee SHALL check new repository is working (like succeeded to push something,
> and to access repository admin panel) and mark as 'DONE', but a requestee does not need to check PR
> for public web site (etc.).

Comment by hassan [ 17/Aug/18 ]

Ok, but the same link mentions:

3. Add a line of new repository to repos.html and about.html, with a PR branch named as the repository creation ticket and sysadmin as reviewer (not a requestee). Just merge if updated website is fine.

and

Once operation procedure finished [...]

So given that the branch has not been merged yet, I presumed that the ticket was marked as 'in review' a little early.

But in any case I see that the html updates are independent of a GitHub repository review so will arrange for that to happen.

Comment by shimono [ 18/Aug/18 ]

I could NOT see the latter part.
it says explicitly
> Also, sysadmin SHALL work on 'pfs_www_pipe' PR independently.

Comment by hassan [ 18/Aug/18 ]

I don't understand by your first sentence

I could NOT see the latter part.

But regarding your second point:

it says explicitly

> Also, sysadmin SHALL work on 'pfs_www_pipe' PR independently.

I had also seen that sentence. But it appears to contradict the previous sentence (that I partly quoted in my above comment). So I suggest the text in that section should be made more clear.

As I have mentioned already, I will arrange the testing of the GitHub repo independently in any case.

Comment by shimono [ 18/Aug/18 ]

ah, I found it in the requestee part as
> Once operation procedure finished, this ticket will be marked 'IN REVIEW' with a requestee as a reviewer by sysadmin,
which has been finished as marking 'IN REVIEW'.

Ok. I've not wrote procedure in clear way, following Naoyuki's direction that we shall keep procedure as smooth/unclear/floating one, but I'll try to make things as clear as possible like normal OSS way. let me have some time to work on it.

Comment by hassan [ 22/Aug/18 ]

cloomis Can you test the repo please?

Comment by hassan [ 31/Aug/18 ]

Simple tests performed (add new file, commit, push; delete file, commit, push) on new git repo. All OK.

Comment by hassan [ 31/Aug/18 ]

As PR #39 has been merged, ticket can now be resolved.

Comment by hassan [ 12/Sep/18 ]

shimono or yuki.moritani: can we resolve this issue now?

Comment by yuki.moritani [ 13/Sep/18 ]

hassan I'm sorry ... I couldn't understand your point exactly.

So I think the reporter (I'm afraid you, Hassan, this time) can change the status as "done".

Comment by hassan [ 13/Sep/18 ]

I understand now. I apologize - I am very used to the assignee or JIRA project custodian resolving issues in general.
Will resolve.

Comment by hassan [ 13/Sep/18 ]

Repo created and tested OK.

Generated at Sat Feb 10 16:50:34 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.