[FIBERALLOC-39] Common code in ets_fiber_assigner and ets_shuffle Created: 10/Mar/21  Updated: 07/Mar/23  Resolved: 07/Mar/23

Status: Done
Project: Target to fiber allocation and configuration
Component/s: ets_fiberalloc, ets_shuffle
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Martin Reinecke Assignee: Martin Reinecke
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

According to the current plans, both the ets_fiber_assigner and ets_shuffle components will share a lot of common functionality (e.g. reading/writing PFS designs/configs and accessing data bases), I plan to write several convenience functions that are used by both packages, and to improve maintainability I prefer not to duplicate this code.

Possible options are:

  • the common code is put into ets_fiber_assigner, and ets_shuffle depends on ets_fiber_assigner
  • the common code is put into ets_shuffle, and ets_fiber_assigner depends on ets_shuffle
  • the common code goes into a new repository, and both packages depend on that

I'd prefer one of the first two options, since it avoids the bureaucracy necessary to introduce a new package, but I'd be happy to hear other opinions. mxhf , hassan ?



 Comments   
Comment by Martin Reinecke [ 17/Mar/21 ]

I have started implementing option 1, but it is no problem to switch to one of the others later on if desired.

Comment by Martin Reinecke [ 07/Mar/23 ]

This can be closed in my opinion.

Generated at Sat Feb 10 16:53:13 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.