[DAMD-69] Rename pfsSpectra and pfsSpectrum Created: 20/Dec/19 Updated: 05/Jan/21 Resolved: 25/Mar/20 |
|
| Status: | Done |
| Project: | Data Model |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | hassan | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 1 | ||||||||
| Sprint: | 2DDRP-2021 A | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
The names pfsSpectra.py and pfsSpectrum.py are confusing. For example, a pfsSpectra object does not strictly contain multiple pfsSpectrum s. Consider alternative names. |
| Comments |
| Comment by price [ 05/Mar/20 ] |
|
I don't think I'm the person to ask to consider new names, as I've already given them the best names I could think of. I'm happy to implement this once new names are decided, but that needs input (and probably a directive) from people who aren't me. |
| Comment by price [ 20/Mar/20 ] |
|
rhl says: "PfsFiberArray and PfsFiberArraySet. I really don't want to use a word related to spectrum when (as you point out) we have a Spectrum and SpectrumSet already". |
| Comment by price [ 20/Mar/20 ] |
|
We also need to muck with the docstrings in the inheritance to replace any instances of the base class name. |
| Comment by price [ 24/Mar/20 ] |
|
Changes only to the implementation: rename the classes, and fix up the docstrings. |
| Comment by price [ 25/Mar/20 ] |
|
Merged to master. |