[DAMD-65] Retrospective approval of 2D pipeline-related changes Created: 29/Aug/19  Updated: 26/Sep/19  Resolved: 26/Sep/19

Status: Done
Project: Data Model
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to DAMD-63 Redesign and implement pfsObject FluxTbl Done
relates to PIPE2D-310 Modify pipeline flow to match design Done
Story Points: 5
Sprint: 2DDRP-2019 G
Reviewers: hassan

 Description   

The implementation of the 2D pipeline (most notably in PIPE2D-310) involved several changes to the datamodel that were not approved through the usual change control procedure, but were nevertheless merged. This ticket seeks retrospective approval for those changes.

I will survey the 2D pipeline products as currently implemented, use this to update datamodel.txt, and provide a summary here of the changes which can be debated.

 Comments   
Comment by price [ 31/Aug/19 ]

Here are the changes I'm proposing to the datamodel:

  • Added calibDate to bias, dark, flat, fiberTrace filenames (I think this is potentially useful, but easy to remove if there's disagreement).
  • Updated the header keywords used to track the inputs for calibs: "VISIT%03d" --> "CALIB_INPUT_%d" (set by LSST code)
  • Added "targetType" in pfsDesign/pfsConfig (was missing)
  • Specify degrees for pfsDesign/pfsConfig boresight coordinates (missing)
  • Changed name of HDU "CONFIG" --> "IDENTITY" in pfsArm and fixed order of HDUs (to match implementation)
  • Added catId to directory structure for pfsObject (overlooked in previous revisions)

Here's the diff of changes to datamodel.txt.

I've also made several code changes to bring the implementation into compliance with the datamodel (see GitHub pull requests).

Note: pfsObject is not compliant after these changes; that's DAMD-63.

Comment by price [ 26/Sep/19 ]

Merged to master.

Generated at Sat Feb 10 15:33:52 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.