[DAMD-59] How can I make pfsArm object? Created: 11/Jun/19 Updated: 22/Aug/19 Resolved: 22/Aug/19 |
|
| Status: | Won't Fix |
| Project: | Data Model |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | Kiyoto Yabe | Assignee: | price |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | 2DDRP-2019 F | ||||||||
| Description |
|
I'm checking the latest datamodel (60d300c77b67207001aeeb84468436722b224009) now, but I'm not sure how to make pfsArm file. Is pfsArm.py dismissed? |
| Comments |
| Comment by hassan [ 11/Jun/19 ] |
|
Following some refactoring earlier this year, the PfsArm class has been refactored and moved to drp.py. Here's skeleton code for creating a PfsArm file:
from pfs.datamodel.drp import PfsArm
[...]
PfsArm(dataId, fiberIds, wavelength, flux, mask,
sky, covar, flags, metadata)
For the constructor parameters, see also the docString for parent class PfsSpectra in pfsSpectra.py . |
| Comment by hassan [ 11/Jun/19 ] |
|
Assigned to price to provide additional support. |
| Comment by Kiyoto Yabe [ 12/Jun/19 ] |
|
OK. I'll give it a try. |
| Comment by Kiyoto Yabe [ 12/Jun/19 ] |
|
Then, another question arises. How can I make a pfsObject from a set of pfsArm objects? Previously, we used makePfsObject.py but it seems to be outdated. Is it possible to update makePfsObject.py? Or, is there an easy way to do that? |
| Comment by price [ 20/Jun/19 ] |
|
Can you use the MergeArmsTask in drp_stella? If not, what are you trying to do? The DRP design document is slightly outdated now, but it might be useful to read. |
| Comment by Kiyoto Yabe [ 20/Jun/19 ] |
|
We can use it if it is included in datamodel package. We (ETC users) don't want to install the DRP packages. What I want to do is just to make both pfsArm and pfsObject fits files with simulated spectra included. I could make pfsArm file using drp.py but not for pfsObject... |
| Comment by price [ 21/Jun/19 ] |
|
Making a PfsObject from PfsArm files necessarily involves algorithmic code (interpolation and coaddition), which I think would be good to keep out of the data model package. Perhaps you could copy the implementation from MergeArmsTask? Alternatively, I have been working on updating the 1D simulator (ticket |
| Comment by price [ 22/Aug/19 ] |
|
I think the remaining questions are addressed in |