[DAMD-49] Clarify use of expId Created: 04/Apr/19  Updated: 11/Jun/19  Resolved: 24/May/19

Status: Done
Project: Data Model
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: hassan Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks DAMD-57 Implement range of datamodel changes Done
Relates
relates to PIPE2D-434 ingestPfsImages.py fails when no pfsC... Done
relates to DAMD-48 in pfsObject, covar shape should be (... Won't Fix
relates to DAMD-42 Reconsider the details of the pfsConf... Done
relates to DAMD-32 Split pfsConfig into pre- and post- m... Done

 Description   

This ticket has been separated out from DAMD-42.

The concept of expId had been introduced as part of DAMD-32, but with limited information. Please clarify the rationale of introducing this new field.

DAMD-32 introduces additional code in relation to expId. If it is agreed that expId is not required, should it be replaced or removed? If the former, what existing information should it be replaced with?



 Comments   
Comment by price [ 25/Apr/19 ]

Craig and I thought expId would be preferable (visit is an LSST-ism), so I tried to replace visit with expId but found that visit is hard-wired in the LSST Butler in places. Hopefully it won’t be in the next version of the butler, but that’s a while away. I don't care either way, and suggest we just go with visit (at least in the pipeline; the instrument software shouldn't care what the pipeline calls it).

Comment by cloomis [ 25/Apr/19 ]

+1 on visit – it is time to choose one term and to use it consistently. Including the instrument software.

Comment by hassan [ 26/Apr/19 ]

Following 2D DRP tech telecon earlier today - agreed to replace expId with visit. Some technical details (use of expId and visit) in certain calls) to be discussed between price and hassan.  

Comment by hassan [ 07/May/19 ]

Additionally, replace expHash with pfsVisitHash .

Comment by hassan [ 24/May/19 ]

Merged to master (commit 457f484).

Generated at Sat Feb 10 15:33:42 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.