[DAMD-140] Add pfsDesign "variant" field, to be added to the SHA. Created: 09/Nov/22 Updated: 08/Feb/23 Resolved: 19/Nov/22 |
|
| Status: | Done |
| Project: | Data Model |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | 2DDRP-2023 A | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
We sometimes want to distinguish between pfsDesigns which otherwise might have the same SHA. Two cases are when testing/changing the fibertypes for a given static design, and for distinguishing between designs with sub-arcsec offsets between them. The proposal is to add a optional VARIANT field to the design which would be incorporated to the SHA. If the field does not exist (as for all existing pfsDesigns), the SHA would be unchanged. |
| Comments |
| Comment by arnaud.lefur [ 12/Nov/22 ] |
|
As discussed in commissioning telecon, we also need to add pfsDesignId0 (which is == to pfsDesignId is most cases). |
| Comment by hassan [ 12/Nov/22 ] |
|
I think we should stick with this one, so update the proposal with an optional pfsDesignId0 (such that both keywords pfsDesignId0 and VARIANT are present, or not at all) to this ticket. |
| Comment by cloomis [ 14/Nov/22 ] |
|
Adding .variant from VARIANT, and .designId0 from PFDSGN0. Require either both or neither to be set, and and make both 0 if we are not a variant (includes older designs) This is backward-compatible and only adds two PFDU cards, so am not bumping DAMD_VER. Note that since the pfsConfig.write} call requires an already calculated hash, the caller must add add {{variant=N to the utils.calculate_pfsDesign call. |
| Comment by hassan [ 14/Nov/22 ] |
|
All changes look fine. I think we are missing a test for calculate_pfsDesignId that could be added. |
| Comment by hassan [ 19/Nov/22 ] |
|
Already merged to master. |