[DAMD-139] Review Redshift Candidates description, warning flags and errors Created: 21/Oct/22  Updated: 25/Jan/24

Status: Open
Project: Data Model
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Ali Allaoui Assignee: Ali Allaoui
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE1D-67 Update for drp1d 0.38.0 Done

 Description   

Warning flags evolution:
Each solver has warning flags, not only redshift solvers, so we add flags for galaxy and qso line measurement solvers and for classification solver.
Error handling has evolved in drp1d_pipe 0.38, the pipeline does not stop if a solver fails, so we add an error code for each solver. The result is the modification of first header of redshift candidates product :

GALAXY_LWARNING INT64 Quality flags for galaxy line measurement solver
QSO_LWARNING INT64 Quality flags for QSO line measurement solver
CLASSIFICATION_WARNING INT64 Quality flags for classification solver
GALAXY_ZERROR INT64 Error code for galaxy solver
QSO_ZERROR INT64 Error code for QSO solver
STAR_ZERROR INT64 Error code for star solver
GALAXY_LERROR INT64 Error code for galaxy line measurement solver
QSO_LERROR INT64 Error code for QSO line measurement solver
CLASSIFICATION_ERROR INT64 Error code for classification solver

https://github.com/Subaru-PFS/datamodel/blob/e76f0b5a2d483b09142f42fbbb407a114b842246/datamodel.txt#L890

 Comments   
Comment by Masayuki Tanaka [ 08/Nov/22 ]

Looks good to me. Just one question. The line measurement flags are a 'master' flag; there is only one flag for one object.  I do not know the detailed line measurement algorithm, but you do not anticipate a situation like the line measurement fails only for a subset of the lines and the other lines are OK?

...by the way, looking at the datamodel, I found that line fluxes are in units of 10^-35 W/m2, while the continuum level is reported in nJy.  Is there a reason why you use different units?

 

Comment by Ali Allaoui [ 25/Jan/24 ]

the warning flag documentation will be embedded in pfsZCandidates files with https://pfspipe.ipmu.jp/jira/browse/PIPE1D-78

Generated at Sat Feb 10 15:34:40 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.