[DAMD-137] Support proper motion and parallax for targets in pfsDesign files Created: 04/Oct/22  Updated: 25/Jul/23  Resolved: 25/Jul/23

Status: Done
Project: Data Model
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: monodera
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File log.pytest_test_PfsConfig    
Story Points: 2
Sprint: Eng12July

 Description   

As discussed on the #obsproc slack channel on 2022-10-02, we need to support fast-moving objects for PFS.

The GUIDESTARS table does have proper motion support as we were worried about extra-Galactic sources, but we didn't think about target stars.

Please add epoch, pmRa, pmDec, parallax to the DESIGN table, with definitions identical to those for the guidestars.

When designing plates we need to pay attention to these columns, but the exact observing date shouldn't matter (as we finalise the cobra positions just before observing).

 Comments   
Comment by monodera [ 17/Jul/23 ]

I made a pull request as follows.

https://github.com/Subaru-PFS/datamodel/pull/117

I also ran pytest with "python3 -m pytest -v ./tests/test_PfsConfig.py" and appeared to succeed (log file is attached as log.pytest_test_PfsConfig).

New parameters (epoch, pmRa, pmDec, and parallax) are put after fiberstatus argument when initializing the classes. If there is a more suitable place, please let me know.

Comment by monodera [ 19/Jul/23 ]

Apparently, the integration test fails because of no backward compatibility at this moment. I'm wondering how it shoudl be implemented. Can I just ignore the existence of these new columns (epoch, pmRa, pmDec, and parallax) when reading a pfsDesign? (maybe throw a warning or info?)

Here is the link to the line where columns are checked.
https://github.com/Subaru-PFS/datamodel/blob/350664261593366ba36d28ab5a43900546be4429/python/pfs/datamodel/pfsConfig.py#L502

The same also applies to DAMD-146 (proposalId and obCode).

Comment by price [ 19/Jul/23 ]

There are examples of backward compatibility in the lines after the one you point to.

If any of the columns is not present, set it to a reasonable default (epoch="J2000.0", pmRa=0, pmDec=0, parallax=0).

Comment by arnaud.lefur [ 24/Jul/23 ]

Looks good, backward compatibility is working.
When also need to update opdb schema, eg adding proper columns in pfs_design_fiber and modify the ingest script to populate those.

Comment by Kiyoto Yabe [ 24/Jul/23 ]

I have updated the opDB schema. Please see the ticket branch for the column names.

Comment by arnaud.lefur [ 25/Jul/23 ]

All products has been merged and tagged as w.2023.30a.
Currently running on the summit / hilo

Generated at Sat Feb 10 15:34:38 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.