|
Following discussions between Yoshida, Hiroshige, yuki.moritani and cloomis, it has been agreed that the agId should start at 0.
Yoshida, Hiroshige comments:
I don't know a definitive answer. Certainly, it is more convenient
internally to use a zero-based numbering system (e.g., for indexing
arrays), and that is what I do in the current implementation of the AG
subsystem and opDB/FITS data it generates. On the other hand, the AG
cameras are currently numbered 1 through 6, so we may eventually need to
convert between zero-based and one-based numbering systems somewhere,
likely when data products are generated, consumed, and/or presented.
Comments from Craig:
I don’t feel very strongly about it. Given the choice I always prefer 0-based. But it is true and unchangeable that all the PFI ids (cobras, fibers, holes, modules, boards, fields, etc) are 1-based. If we will really talk about the AGs as part of the PFI we should probably make them 1-based. But I think we will not: the AGs are imagers and simply set the field. So I vote for 0-based.
|