[DAMD-121] Adjust SHA creation string coordinate precision. Created: 22/Sep/21 Updated: 24/Sep/21 Resolved: 24/Sep/21 |
|
| Status: | Done |
| Project: | Data Model |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | price |
| Description |
|
datamodel.txt specifies that we should hash coordinates rounded to nearest arcsecond. The code in utils.py uses "%d %.0f %.0f" % (fiberId, ra, dec), which rounds to the degree. I'm assuming that by "arcsecond" we can mean 10^-4 degrees? |
| Comments |
| Comment by cloomis [ 22/Sep/21 ] |
|
The fix would be trivial, but I worry about what will break. Any survey design hashes would change. How much does that matter: do we need to be regenerate SHAs, or can we treat old ones as opaque labels? If we added/updated some version key? |
| Comment by price [ 24/Sep/21 ] |
|
arnaud.lefur suggests that changes to pfsDesignId following the recent run need to be coordinated. |
| Comment by cloomis [ 24/Sep/21 ] |
|
Merged at 2795b11 |