[DAMD-120] Add designName to pfsDesign header? Created: 23/Sep/21  Updated: 22/Jun/22  Resolved: 02/Nov/21

Status: Done
Project: Data Model
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: hassan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-1428 PfsDesign/pfsConfig viewer tool Done
relates to INSTRM-1437 Add `design_name` in `pfs_design` table Done
relates to INSTRM-1348 Ingest pfsDesign/pfsConfig files to opDB Done
Story Points: 1
Sprint: 2DDRP-2021 A 10, 2DDRP-2021 A11
Reviewers: price

 Description   

By popular demand: can we add an optional design name card to pfsDesign files? e.g. PfsDesign(id, ra, dec, ...., configName="odd fibers under black dots") turning into a FITS card?

Can do here if acceptable.

 Comments   
Comment by rhl [ 24/Sep/21 ]

Sounds OK to me. I suspect we'll need a richer annotation than that, but this is a good start.

Comment by hassan [ 01/Oct/21 ]

No objections to the proposal from the DRP (meeting 2021-09-24).

Comment by price [ 02/Nov/21 ]

Need to fix the header keyword choice.
Don't bump DAMD_VER.
Fix numpydoc.
Expand tests.

Generated at Sat Feb 10 15:34:28 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.