[DAMD-119] Change datamodel.txt to specify pfiNominal/pfiCenter mm, not microns Created: 23/Sep/21 Updated: 02/Nov/21 Resolved: 02/Nov/21 |
|
| Status: | Done |
| Project: | Data Model |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | hassan |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Sprint: | 2DDRP-2021 A 10, 2DDRP-2021 A11 |
| Reviewers: | price |
| Description |
|
Datamodel.txt specifies that positions in the focal plane are specified in microns. On the Sept 2021 run (the first time we really designed pfsDesign files) we used mm, and on reflection this makes sense at those are the units used in PFI geometry. I propose that we make this official, but am of course open to counter arguments. |
| Comments |
| Comment by price [ 23/Sep/21 ] |
|
As the original author, I agree with the proposed change. |
| Comment by hassan [ 01/Oct/21 ] |
|
No objections to the proposal from the DRP (meeting 2021-09-24). |
| Comment by price [ 02/Nov/21 ] |
|
I suggest not bumping the DAMD_VER because this change doesn't affect pfsConfig files in the wild; if we do bump the DAMD_VER, we should use DAMD_VER to modify values on read. There's an associated trivial change needed in drp_instmodel. |