[DAMD-111] Change special meaning of pfsDesignId 0x0 Created: 07/May/21  Updated: 15/Jun/21  Resolved: 03/Jun/21

Status: Done
Project: Data Model
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: hassan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE2D-832 Add no-fibre setup to makeDummyCableB... Done
Story Points: 1
Sprint: 2DDRP-2021 A 4, 2DDRP-2021 A5

 Description   

When I wrote the original datamodel I included the sentence:

As a convenience to simulators, if the fiberIds in a pfsConfig file are consecutive integers starting at 1 and all ra/dec values are 0.0 the pfsDesignId is taken to be 0x0

In practice we do not use this loophole, as we use pfsConfig files to define the inputs to the simulator. I'd like to remove this dispensation and use 0x0 to mean, "No illuminated fibres". A lawyerly reading of the current rule includes this case, but I think it'd be clearer to change it to:

A pfsDesignId of 0x0 means that no fibres are illuminated.

 



 Comments   
Comment by hassan [ 03/Jun/21 ]

No comments regarding proposed change.

Trivial textual fix.

Generated at Sat Feb 10 15:34:22 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.