[DAMD-11] Create or adapt file to include per-fiber+row wavelengths. Created: 10/Nov/16 Updated: 12/May/18 Resolved: 12/May/18 |
|
| Status: | Done |
| Project: | Data Model |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | cloomis | Assignee: | aritter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The 2d pipeline needs a seed solution for fiber positions and wavelengths, both to identify the fiber traces and to initialize the wavelength solution for arc line matching. The simulator knows the geometry from the input jemax spot files and is currently supplying stella with a one-off (fiber#, y) -> (x, lambda) FITS table. We would like to use proper datamodel files to encapsulate the table. There is an existing pfsFiberTrace file which can hold the (fiber#, y) -> x mapping, but it does not have space for wavelength info. Surely we want to persist wavelength solutions outside of pfsArm files, since the maps will get applied to several image files. Not sure whether we should: Now that I write it down, 2 looks too gross. So 1? Shall I? |
| Comments |
| Comment by aritter [ 14/Nov/16 ] |
|
I thought we had agreed on adding the (fiber#,y)->lambda map to the existing pfsFiberTrace file, which I can easily do if you give me the map. Is there any difference between this map and the file you created for |
| Comment by cloomis [ 14/Nov/16 ] |
|
As much as I'd like to for neatness sake, putting the lambda map in ``pfsFiberTrace`` files would require two forms of the ``pfsFiberTrace`` file, because of the order in which new flats and arcs are measured, and that the file would need to be rewritten or appended to. Basically, the lambda map would be different before and after the arc exposure is processed. If anyone can think of a clean way of dealing with this it'd be great. I assert that rewriting FITS files is evil, though. Hence some ``pfsFiberWaves`` file just to hold the new arc solution, which was measured using the traces from the ``pfsFiberTrace`` file. The hack version I emailed you is essentially the same as the earlier version. I bumped the ``xc`` and ``pixelWave`` columns to doubles, and dropped the entirely redundant ``yc``. |
| Comment by rhl [ 15/Nov/16 ] |
|
I think I proposed that the command would take both the flat(s) and the arc(s) and solve both problems before performing any output. Does this solve your problem? |
| Comment by cloomis [ 16/Nov/16 ] |
|
Is the proposal that we would then have:
Is that what you have in mind? Is there any scenario where the arc extraction process would modify/tweak the fiber traces? |
| Comment by aritter [ 16/Nov/16 ] |
|
I think what RHL has in mind is to put everything into the pfsFiberTrace file which would be created by one command that extracts the FiberTraces from the Flats and the wavelength solution from the Arcs. In this case no re-writing or appending is required. I guess that would mean that we have one seed pfsFiberTrace file from the simulations which is read in as a 'guess' by the task which produces the output pfsFiberTrace file. |
| Comment by cloomis [ 06/Dec/16 ] |
|
Since stella both generates and consumes the wavelength solution I think it would make more sense for Andreas/Stella to make the datamodel additions – I'd have to guess at some implementation details. |
| Comment by hassan [ 12/May/18 ] |
|
Following discussions with cloomis, the DetectorMap addresses this. |