Uploaded image for project: 'DRP 2-D Simulator'
  1. DRP 2-D Simulator
  2. SIM2D-109

Refactor code such that PfsConfigs are not dark/flat/science specific

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Done (View Workflow)
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      2DDRP-2019 C

      Description

      Following SIM2D-94 it was noticed that there is code in makePfsConfig.py to make flat or dark-specific PfsConfig s.

      As cloomis had remarked in PR #3 for the above issue:

      I do not think that pfsConfig can or should hold any information about what light goes through a fiber by declaring makeFlatConfig, makeDarkConfig, etc. The design tells where the cobras are pointed (which can be behind a spot), but that same config is used for taking darks, arcs, flats, and science exposures.

      Please make the generated pfsConfigs independent of flats, darks or science.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                price price
                Reporter:
                hassan hassan
                Reviewers:
                cloomis
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: