Uploaded image for project: '1D Redmine '
  1. 1D Redmine
  2. REDMINE1D-344

[RM-8433] [parameters] wrong enableIGM in load_linecatalog

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Review Complete (View Workflow)
    • Priority: Normal
    • Resolution: Unresolved
    • Labels:
      None

      Description

      Created on 2023-10-23 13:36:20 by Didier Vibert. % Done: 100

      since #8048, inside load_linecatalog, the enableIGM boolean is wrongly computed

      before #8048 the value was
      <pre><code class="python">
      enableIGM = self.parameters[object_type][method]["linemodel"]["igmfit"]
      </code></pre>

      whereas, now it is
      <pre><code class="python">
      enableIGM = self.parameters.get_solve_method_igm_fit(object_type, solve_method)
      </code></pre>

      and the code of @get_solve_method_igm_fit@ is
      <pre><code class="python">
      def get_solve_method_igm_fit(self, object_type: str, solve_method: str) -> bool:
      igmfit = None
      if solve_method == "LineModelSolve":
      igmfit = self.get_lineModelSolve_igmfit(object_type)
      elif solve_method == "TemplateFittingSolve":
      igmfit = self.get_templateFittingSolve_igmfit(object_type)
      elif solve_method == "TplcombinationSolve":
      igmfit = self.get_templateCombinationSolve_igmfit(object_type)
      return igmfit

      </code></pre>

      inside load_linecatalog, the @get_solve_method_igm_fit@ can be @"LineModelSolve"@ or @"LineMeasSolve"@

      thus @"LineMeasSolve"@ is missing

        Attachments

          Activity

            People

            • Assignee:
              r2j.migrate Redmine-Jira Migtation
              Reporter:
              r2j.migrate Redmine-Jira Migtation
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: