Uploaded image for project: '1D Redmine '
  1. 1D Redmine
  2. REDMINE1D-314

[RM-8310] [linemodel] wrong output of some line ratio parameters

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Done (View Workflow)
    • Priority: Normal
    • Resolution: Done
    • Labels:
      None

      Description

      Created on 2023-09-20 11:20:46 by Didier Vibert. % Done: 100

      after the end of the loop on line-ratio, the method @CTplratioManager::finish@ should refresh the elements with the fitted values coming from the best line ratio.

      • -the amplitude is wrongly refreshed because all the nominal amplitudes were not refreshed...
        This has an impact on the computed model, and on the amplitude and flux of individual lines (including Ha complex and OII doublet). But the global amplitude and line ratio name are ok (since the call to @TLineModelResult::updateTplRatioFromModel@ at the end of @COperatorLineModel::buildExtremaResults@). The pdf and chisquare are ok too, with the redshift solution.-
      • the Lya asym parameters are not refreshed if the profile is ASYM (instead of ASYMFIT) because @CLine::SetAsymParams@ does nothing in ASYM case

      maybe fixed by using LoadModelSolution

      other bugs found:

        Attachments

          Activity

            People

            • Assignee:
              r2j.migrate Redmine-Jira Migtation
              Reporter:
              r2j.migrate Redmine-Jira Migtation
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: