Uploaded image for project: '1D Redmine '
  1. 1D Redmine
  2. REDMINE1D-18

[RM-6447] first pass results are wrong

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Done (View Workflow)
    • Priority: Normal
    • Resolution: Done
    • Labels:
      None

      Description

      Created on 2021-04-14 07:24:06 by Didier Vibert. % Done: 100

      when dealing with #6340 I have seen a bug in the way the hdf5 outputs are getting the first pass results. These results are in the resultstore, but the global @COperatorResultStore::getCandidateData@ which are calling the derived function on each result is wrong for the first pass results. There are taken from the final result @linemodel_extrema@ in the resulstore instead of the first pass results (@linemodel_firstpass_extrema@) and are thus equal to 2nd pass results).

      we can either:

      • correct for this right now ( the fix seems easy, since all the 1st pass hdf5 attributes have their name beginning with the string "FirstPass" we can check for this in @COperatorResultStore::getCandidateData@ and call the derived @getCandidateData@ on the correct result (@linemodel_firstpass_extrema@)
      • wait for #6343

        Attachments

          Activity

            People

            • Assignee:
              r2j.migrate Redmine-Jira Migtation
              Reporter:
              r2j.migrate Redmine-Jira Migtation
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: