Uploaded image for project: 'DRP 2-D Pipeline'
  1. DRP 2-D Pipeline
  2. PIPE2D-657

Fix makeDummyCableBDesign for missing PfsDesign fields

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done (View Workflow)
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      DAMD-83 and DAMD-85 changed the fields contained in PfsDesign, but we neglected to update makeDummyCableBDesign in pfs_utils.

      $ makeDummyCableBDesign.py '12mtpS34'
      Traceback (most recent call last):
        File "/software/drp/stack/miniconda3-4.5.12-1172c30/Linux64/pfs_utils/w.2020.47a/bin/makeDummyCableBDesign.py", line 8, in <module>
          main()
        File "/software/drp/stack/miniconda3-4.5.12-1172c30/Linux64/pfs_utils/w.2020.47a/python/pfs/utils/dummyCableB.py", line 266, in main
          design = makePfsDesign(pfsDesignId, fiberId)
        File "/software/drp/stack/miniconda3-4.5.12-1172c30/Linux64/pfs_utils/w.2020.47a/python/pfs/utils/dummyCableB.py", line 245, in makePfsDesign
          fiberMags, filterNames, pfiNominal)
      TypeError: __init__() missing 5 required positional arguments: 'fiberFluxErr', 'psfFluxErr', 'totalFluxErr', 'filterNames', and 'pfiNominal'
      

        Attachments

          Activity

            People

            • Assignee:
              price price
              Reporter:
              price price
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: