[PIPE2D-492] Miscellaneous changes to the 2D DRP pipeline - PFS-JIRA

XML

Word

Printable

Details

Type: Story
Status: Done (View Workflow)
Priority: Normal
Resolution: Done
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Story Points:
1
Sprint:
2DDRP-2021 A

Description

Following preparations towards the PFS Collaboration Meeting Dec 2019, rhl encountered a number of areas of improvement. His initial rough notes are copied here, but separate tickets based on these notes, and additional related points post-meeting, will be filed as child tickets in due course.

 get("detectormap") – need to decide on good names for the butler
 detMap.fiberIds v. pfsArm.fiberId
 pfsArm.resample docs claim to return a pfsSpectra object not a pfsArm
 afwGeom -> geom change
 What happened to
 stella.utils.addFiberTraceSetToMask
 drpStella.markFiberTraceInMask(ft, mask, ftMask)
 ? Superceded by FiberTrace.getTrace():
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 from pfs.drp.stella import fiberMaskPlane
 def addFiberTraceSetToMask(mask, fiberTraceSet, display=None):
 mask.addMaskPlane(fiberMaskPlane)

for ft in fiberTraceSet:
 ftMask = ft.trace.mask
 calexp.mask[ftMask.getBBox()] |= ftMask

if display:
 display.setMaskPlaneColor(fiberMaskPlane, "GREEN")
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 - It looks as if we're not updating the DetectorMaps' fibre trace *columns* in calibrateWavelength. An old RHL problem, but it may be why the vector plots are weird (or why you built them off arcs!)
 - It looks as if you cannot run reduceArc on calexps. Is there a way to avoid rerunning ISR? The problem is actually in reduceExposure
 pfsSpectra.py and pfsSpectrum.py are confusing names
 The datamodel probably needs to define the values of the targetType enum. They also need to go in the header
 Now we're writing pfsSky the datamodel needs to be fleshed out. Looking at the code I don't understand the model; I'd expect it to be per-fiberId not position
 pfsConfig.objId[pfsConfig.targetType == TargetType.SKY] returns an array of 0s; we need real IDs for skies
 pfsArm files don't seem to fill out the sky HDU

Attachments

Issue Links

relates to

DAMD-69 Rename pfsSpectra and pfsSpectrum

Done

DAMD-71 TargetType should be defined in datamodel.txt and headers

Done

DAMD-73 PfsArm needs additional information to recover raw counts

Done

PIPE2D-493 SKY HDU is not populated in pfsArm files

Done

PIPE2D-497 Update references to lsst.afw.geom to lsst.geom

Done

PIPE2D-498 Revise reference name for detectormap in the butler

Done

PIPE2D-499 Make detectorMap.fiberIds and pfsArm.fiberId consistent

Done

PIPE2D-500 pfsArm.resample docString claims to return a pfsSpectra not pfsArm

Done

PIPE2D-502 Correct detectormaps for spatial effects as well as wavelength effects

Done

PIPE2D-503 Support for (re-) using calexps in reduceExposure

Done

PIPE2D-505 Provide object identifiers for the sky

Done

DAMD-70 Define the TargetType in the datamodel

Won't Fix

DAMD-72 Provide sky model in datamodel.txt

Won't Fix

PIPE2D-501 addFiberTraceSetToMask missing

Won't Fix

DAMD-67 Update PfsObject to track input visits in the OBSERVATIONS table

Done

PIPE2D-485 calculate_pfsVisitHash updates

Done

DAMD-68 datamodel.txt: include input visits in PfsObject.OBSERVATIONS table

Won't Fix

(12 relates to)

Activity

People

Assignee:

price

Reporter:

hassan

Reviewers:

hassan

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

17/Dec/19 2:14 PM

Updated:

04/Jan/21 8:23 PM

Resolved:

07/Apr/20 7:29 PM