-
Type:
Task
-
Status: Done (View Workflow)
-
Priority:
Normal
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:
-
Epic Link:
pfsMerged.flux is not divided by exptime and thus the median of (imag_pfsMerged - imag_PS1) varies with exposure time. This has to be fixed. Also, for open-use programs, we want to anonymize the plot (e.g., mask coordinates, etc) in some occasions. Implement the anonymization option.
I know it is not a good manner to implement two features with a single ticket. But, I want to make a quick update for the on-going run and I hope people are not too upset...
Thank you! Could you open the pull request?
Just specifying --doAnonymize False does not work for me to show full information, but am I doing something wrong? It looks that the default mode is anonymizing info but is it possible to make this default is False and control with parser.add_argument('doAnonymize', default=False, action='store_true')? Is there any reason why anonymization is default?
I fixed the doAnonymize issue and made a pull request. I think the default should be doAnonymize=True to be conservative. We will use the code both for developers and users. If we set the default to False, run the code, and share the plots with the user (by mistake), then we will be in trouble. The other way around is no problem; we just have to run the code again with the option set to False for developers.
Merged. Thank you for reviewing.
Kiyoto Yabe, could you review the ticket branch? The code overall is quite ugly, but I think it works.