Uploaded image for project: 'DRP 2-D Pipeline'
  1. DRP 2-D Pipeline
  2. PIPE2D-1322

Inability to fit aperture corrections can lead to reduceExposure.py failing

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done (View Workflow)
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      When running reduceExposure.py with doMeasureLines=True, an apparent failure to measure aperture corrections leads to the processing failing. In many cases I don't care about the photometry (e.g. if I'm looking at focal plane distortions). For now setting the appCorr to NaN and proceeding might be acceptable. Setting the aperture correction to 1.0 would require that we signal this failure to the user in some other way.

      E.g. the command

      reduceExposure.py /work/drp --calib /work/drp/CALIB --rerun rhl/calibrations-2023-07-v6 -c isr.doFlat=False isr.doFlatNir=True isr.doDark=False useCalexp=True doAdjustDetectorMap=False doMeasureLines=True --id visit=96958 arm=r spectrograph=1
      

      fails with:

      reduceExposure FATAL: Failed on dataId={'visit': 96958, 'arm': 'r', 'spectrograph': 1, 'dateObs': '2023-07-20', 'site': 'S', 'category': 'A', 'field': 'GE_EN1_P1_PA_90', 'ccd': 1, 'filter': 'r', 'expTime': 60.0, 'dataType': 'COMPARISON', 'taiObs': '2023-07-20T09:52:52.553', 'pfsDesignId': 1562097688427952981, 'slitOffset': 0.0}: RuntimeError: No good points
      Traceback (most recent call last):
        File "/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py", line 436, in __call__
          result = self.runTask(task, dataRef, kwargs)
        File "/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py", line 504, in runTask
          return task.runDataRef(dataRef, **kwargs)
        File "/home/rhl/PFS/drp/stella/python/pfs/drp/stella/reduceExposure.py", line 277, in runDataRef
          calibs = self.getSpectralCalibs(sensorRef, exposure, pfsConfig, boxcarWidth)
        File "/home/rhl/PFS/drp/stella/python/pfs/drp/stella/reduceExposure.py", line 599, in getSpectralCalibs
          phot = self.photometerLines.run(exposure, lines[notTrace], detectorMap, pfsConfig, fiberTraces)
        File "/home/rhl/PFS/drp/stella/python/pfs/drp/stella/photometerLines.py", line 99, in run
          phot = self.photometerLines(exposure, referenceLines, detectorMap, pfsConfig, fiberTraces)
        File "/home/rhl/PFS/drp/stella/python/pfs/drp/stella/photometerLines.py", line 177, in photometerLines
          apCorr = self.apertureCorrection.run(exposure, pfsConfig, detectorMap, lines)
        File "/home/rhl/PFS/drp/stella/python/pfs/drp/stella/apertureCorrections.py", line 125, in run
          apCorr = self.fit.run(corrections, pfsConfig, minWavelength=minWavelength,
        File "/home/rhl/PFS/drp/stella/python/pfs/drp/stella/fitFocalPlane.py", line 109, in run
          raise RuntimeError("No good points")
      RuntimeError: No good points
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                rhl rhl
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: