Instrument control developmentIcon indicating the project type

Instrument control development

Uploaded image for project: 'Instrument control development'
  1. Instrument control development
  2. INSTRM-2060

Fix bug in calculation of estimate_magnitude

    Details

    • Sprint:
      Eng13Oct, Engrun15Mar

      Description

      Fix bug in scaling the flux for exposure time correction.

        Attachments

          Issue Links

          relates to

          Task - A task that needs to be done. INSTRM-1979 Calculate flux conversion for AG camera with April Data

          • Normal - Normal priorities
          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            karr karr added a comment -

            Pushed to branch; should test before merging to master. 

            Show
            karr karr added a comment - Pushed to branch; should test before merging to master. 
            Hide
            Permalink
            hiro Yoshida, Hiroshige added a comment -

            agccActor INSTRM-2060 works ok in simulation with the July 2023 data. However, calculated "estimated_magnitude"s are high-20s and 30s. For example, for the exposure agc_exposure_id=384564 (NGC 6633), the brightest is ~26.3 mag, with 22 objects brighter than 30 mag and 437 fainter than 30 mag, and the faintest is ~36.3 mag.

            Show
            hiro Yoshida, Hiroshige added a comment - agccActor INSTRM-2060 works ok in simulation with the July 2023 data. However, calculated "estimated_magnitude"s are high-20s and 30s. For example, for the exposure agc_exposure_id=384564 (NGC 6633), the brightest is ~26.3 mag, with 22 objects brighter than 30 mag and 437 fainter than 30 mag, and the faintest is ~36.3 mag.
            Hide
            Permalink
            karr karr added a comment -

            The bug has been fixed; I need to update the fits for the conversion to match. 

            Show
            karr karr added a comment - The bug has been fixed; I need to update the fits for the conversion to match. 
            Hide
            Permalink
            yuki.moritani yuki.moritani added a comment -

            (recording from discussion on 24 Jan 2024) Jennifer will update pfs_instdata.

            Show
            yuki.moritani yuki.moritani added a comment - (recording from discussion on 24 Jan 2024) Jennifer will update pfs_instdata.
            Hide
            Permalink
            karr karr added a comment -

            The agccActor and pfs_instdata have been updated, the table now contains a non-colour corrected conversion to GAIA magnitudes. 

            Show
            karr karr added a comment - The agccActor and pfs_instdata have been updated, the table now contains a non-colour corrected conversion to GAIA magnitudes. 
            Hide
            Permalink
            karr karr added a comment -

            This should probably be run through the simulator before merging to master. 

            Show
            karr karr added a comment - This should probably be run through the simulator before merging to master. 
            Hide
            Permalink
            karr karr added a comment -

            Merged to master.

            Show
            karr karr added a comment - Merged to master.

              People

              • Assignee:
                karr karr
                Reporter:
                karr karr
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: